[Bug 1032108] Review Request: yarock - A Lightweight and Beautiful Music Player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1032108



--- Comment #55 from James Abtahi <jamescategory@xxxxxxxxx> ---

hum... something is terribly wrong. according to this source:

http://www.cmake.org/Wiki/CMake:How_To_Build_Qt4_Software#Translations

.ts  file are just the xml source translations while the .qm files are the
binary translations which are executed. but the .ts files are installed
directly in the /usr/share/locale/yarock after installation. No .qm file is
there just .ts files.

I think the original author made some mistakes in the src/CMakeLists and the
patch (.installationpath) is really building upon that bad design. Specifically
It doesn't seem right to hard-code /usr/share/locale there. One probably should
use something like this:

install(FILES ${QM_FILES} DESTINATION ${CMAKE_INSTALL_PREFIX}/translations)

but I'm no expert with these translation stuff. However, I've got a feeling
that the source of the problem is in src/CMakeLists.  any ideas?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]