https://bugzilla.redhat.com/show_bug.cgi?id=1034387 --- Comment #8 from Simo Sorce <ssorce@xxxxxxxxxx> --- (In reply to Nalin Dahyabhai from comment #7) > Visible inspection of items previously noted: > * java subpackage now requires jpackage-utils, no longer requires > python-lxml, which I assume means it was a typo after all -> OK > * not a blocker: javadoc not packaged There is no java documentation as far as I can see. > * the only docs that are packaged are AUTHORS/COPYING/NEWS/README ? Yes, for now. > * package binaries are compiled using %{optflags} -> OK > * %post/%postun use -p /sbin/ldconfig to avoid a shell dependency -> OK > * license ("COPYING") is installed with base 'lasso' package -> OK > * subpackages which require base package do so using %{_isa} -> OK > * php subpackage owns %{_datadir}/php/%{name} -> OK > * debuginfo is available (spot-checked shared library and python binding) -> > OK > * main package no longer includes specific Requires: -> OK > * %check section has been added -> OK > > Other than the no-docs thing, it looks pretty good. The timestamps on the > header files don't seem to create problems installing both the 32- and > 64-bit -devel subpackages on my development box, so we can skip that. Yes I thoink we can skip, upstream indicated the willingness to release a new version soon, so that will take care of the timestamps by requireing a lot less patching as well as the FSF Addrsss issue for which I sent a megapatch upstream. > Do you plan on fixing the package to include more documentation? No, not until upstream releases a new package. There are some issues in building the documentation, so I decided to punt on releaseing it in packages for now and defer to when the upstream package fixes some of it better. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review