[Bug 1035661] Review Request: luajit - Just-In-Time Compiler for Lua

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1035661



--- Comment #12 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=6246247

Hmm..

.pc on x86_64 RPM attached:

-------------------------

# Package information for LuaJIT to be used by pkg-config.
majver=2
minver=0
relver=2
version=${majver}.${minver}.${relver}
abiver=5.1

prefix=/usr
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
libname=luajit-${abiver}
includedir=${prefix}/include/luajit-${majver}.${minver}

INSTALL_LMOD=${prefix}/share/lua/${abiver}
INSTALL_CMOD=/usr/lib64/lua/${abiver}

Name: LuaJIT
Description: Just-in-time compiler for Lua
URL: http://luajit.org
Version: ${version}
Requires:
Libs: -L${libdir} -l${libname}
Libs.private: -Wl,-E -lm -ldl
Cflags: -I${includedir}
-------------------------

So I can't approve it now. Problem found!

libdir=${exec_prefix}/lib should be libdir=${exec_prefix}/lib64 on x86_64.

But, you can look at VCS repo of luajit, it now has supported lib64 by
$(MULTILIB) define.

http://repo.or.cz/w/luajit-2.0.git/blob/HEAD:/Makefile
http://repo.or.cz/w/luajit-2.0.git/blob/HEAD:/etc/luajit.pc

Please package 2.1(You should obey the snapshot package guideline), or add
patch to fix that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]