[Bug 1036297] Review Request: libturpial - library needed to new turpial (twitter client) version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1036297

Eduardo Echeverria <echevemaster@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |echevemaster@xxxxxxxxx



--- Comment #3 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
Hi @Edwin

- rename the package to turpial-libturpial or python-libturpial.
- Remove all el5 stuff (buildroot_tag, %clean, rm -rf after %install.
- Add python2-devel or python3-devel as the case may, as BR
- The unversioned macro, %{__python} is deprecated. You should use %{__python2}
- use %build section (You has moved python build in install section, why?)
- Change the permissions of the directories and files that are wrong. Do that
in %install section preferably (Don't use %attr for that, neither %defattr)
- Since F20 doc are unversioned please see
http://fedoraproject.org/wiki/Changes/UnversionedDocdirs.
- Your package generates unowned directories in the documentation because you
hasn't marked them as %doc
- certs shouldn't go in that place, maybe /etc/pki/$name ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]