https://bugzilla.redhat.com/show_bug.cgi?id=1021719 --- Comment #11 from Kevin Fenzi <kevin@xxxxxxxxx> --- Sorry for the delay here... Outstanding things to fix (mentioned in more detail below with !): 1. You need to own the /etc/opensmtpd and /usr/libexec/opensmtpd directories. You can either add them as %dir to files, or remove the /* from them. 2. Are you planning on maintaining this in EPEL as well? If so, you could look at putting conditionals around the sysvinit script. If not, I would remove the sysvinit subpackage entirely. There's 0 point in having it if you aren't shipping in EPEL/rhel, and the FPC recently changed guidelines to disallow shipping them at all. 3. The debuginfo file lacks sources. Either -g isn't getting used to compile or something is stripping the binaries before the debuginfo is generated. 4. There's a few rpmlint issues to look into. Some are bogus, but a few of them actually look like things to be fixed. missing-call-to-setgroups, non-conffile-in-etc, use-old-pam-stack at least. 5. Please use %global instead of %define. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated", "BSD (4 clause)", "ISC", "BSD (3 clause)", "BSD (2 clause)", "BSD". 7 files have unknown license. Detailed output of licensecheck in /home/fedora/kevin/opensmtpd/review- opensmtpd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/libexec/opensmtpd, /etc/opensmtpd [!]: Package must own all directories that it creates. Note: Directories without known owners: /etc/opensmtpd, /usr/libexec/opensmtpd [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. [x]: Package is known to not require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Buildroot is not present Note: Buildroot: present but not needed [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in opensmtpd- sysvinit [x]: Package functions as described. [x]: Latest version is packaged. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _with_pam 1 [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: opensmtpd-5.4.1p1-0.1.201311182347.fc21.x86_64.rpm opensmtpd-sysvinit-5.4.1p1-0.1.201311182347.fc21.noarch.rpm opensmtpd-5.4.1p1-0.1.201311182347.fc21.src.rpm opensmtpd.x86_64: W: spelling-error %description -l en_US mta -> mat, mt, ma opensmtpd.x86_64: W: spelling-error %description -l en_US sendmail -> send mail, send-mail, Sendai opensmtpd.x86_64: W: incoherent-version-in-changelog 5.4.1p1-0.1.denf ['5.4.1p1-0.1.201311182347.fc21', '5.4.1p1-0.1.201311182347'] opensmtpd.x86_64: E: missing-call-to-setgroups /usr/libexec/opensmtpd/mail.local opensmtpd.x86_64: W: only-non-binary-in-usr-lib opensmtpd.x86_64: W: manual-page-warning /usr/share/man/man5/aliases.opensmtpd.5.gz 52: warning: macro `Ba' not defined opensmtpd.x86_64: W: non-conffile-in-etc /etc/pam.d/smtp.opensmtpd opensmtpd.x86_64: W: manual-page-warning /usr/share/man/man5/smtpd.conf.5.gz 497: warning: macro `Ba' not defined opensmtpd.x86_64: W: manual-page-warning /usr/share/man/man5/smtpd.conf.5.gz 886: warning: macro `Gt' not defined opensmtpd.x86_64: E: non-standard-dir-perm /var/empty/smtpd 0711L opensmtpd.x86_64: W: no-manual-page-for-binary mailq.opensmtpd opensmtpd.x86_64: W: no-manual-page-for-binary newaliases.opensmtpd opensmtpd.x86_64: W: non-standard-dir-in-var empty opensmtpd.x86_64: E: use-old-pam-stack /etc/pam.d/smtp.opensmtpd (line 2) opensmtpd-sysvinit.noarch: W: spelling-error Summary(en_US) SysV -> Sysop opensmtpd-sysvinit.noarch: W: spelling-error Summary(en_US) initscript -> inscription, postscript opensmtpd-sysvinit.noarch: W: spelling-error %description -l en_US initscripts -> postscripts, transcripts, inscription opensmtpd-sysvinit.noarch: W: no-documentation opensmtpd-sysvinit.noarch: W: service-default-enabled /etc/rc.d/init.d/opensmtpd opensmtpd-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/opensmtpd smtpd opensmtpd-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/opensmtpd smtpd opensmtpd-sysvinit.noarch: W: service-default-enabled /etc/rc.d/init.d/opensmtpd opensmtpd-sysvinit.noarch: W: no-reload-entry /etc/rc.d/init.d/opensmtpd opensmtpd.src: W: spelling-error %description -l en_US usr -> use, us, user opensmtpd.src: W: spelling-error %description -l en_US sbin -> sin, bin, bins opensmtpd.src: W: spelling-error %description -l en_US mta -> mat, mt, ma opensmtpd.src: W: spelling-error %description -l en_US sendmail -> send mail, send-mail, Sendai opensmtpd.src: W: strange-permission opensmtpd.init 0755L opensmtpd.src:14: W: unversioned-explicit-provides MTA opensmtpd.src:14: W: unversioned-explicit-provides smtpd opensmtpd.src:14: W: unversioned-explicit-provides smtpdaemon opensmtpd.src:14: W: unversioned-explicit-provides server(smtp) opensmtpd.src:127: E: hardcoded-library-path in /usr/lib/sendmail 3 packages and 0 specfiles checked; 6 errors, 27 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint opensmtpd-sysvinit opensmtpd opensmtpd-sysvinit.noarch: W: spelling-error Summary(en_US) SysV -> Sysop opensmtpd-sysvinit.noarch: W: spelling-error Summary(en_US) initscript -> inscription, postscript opensmtpd-sysvinit.noarch: W: spelling-error %description -l en_US initscripts -> postscripts, transcripts, inscription opensmtpd-sysvinit.noarch: W: no-documentation opensmtpd-sysvinit.noarch: W: service-default-enabled /etc/rc.d/init.d/opensmtpd opensmtpd-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/opensmtpd smtpd opensmtpd-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/opensmtpd smtpd opensmtpd-sysvinit.noarch: W: service-default-enabled /etc/rc.d/init.d/opensmtpd opensmtpd-sysvinit.noarch: W: no-reload-entry /etc/rc.d/init.d/opensmtpd opensmtpd.x86_64: W: spelling-error %description -l en_US mta -> mat, mt, ma opensmtpd.x86_64: W: spelling-error %description -l en_US sendmail -> send mail, send-mail, Sendai opensmtpd.x86_64: W: incoherent-version-in-changelog 5.4.1p1-0.1.denf ['5.4.1p1-0.1.201311182347.fc21', '5.4.1p1-0.1.201311182347'] opensmtpd.x86_64: E: missing-call-to-setgroups /usr/libexec/opensmtpd/mail.local opensmtpd.x86_64: W: only-non-binary-in-usr-lib opensmtpd.x86_64: W: manual-page-warning /usr/share/man/man5/aliases.opensmtpd.5.gz 52: warning: macro `Ba' not defined opensmtpd.x86_64: W: non-conffile-in-etc /etc/pam.d/smtp.opensmtpd opensmtpd.x86_64: W: manual-page-warning /usr/share/man/man5/smtpd.conf.5.gz 497: warning: macro `Ba' not defined opensmtpd.x86_64: W: manual-page-warning /usr/share/man/man5/smtpd.conf.5.gz 886: warning: macro `Gt' not defined opensmtpd.x86_64: E: non-standard-dir-perm /var/empty/smtpd 0711L opensmtpd.x86_64: W: no-manual-page-for-binary mailq.opensmtpd opensmtpd.x86_64: W: no-manual-page-for-binary newaliases.opensmtpd opensmtpd.x86_64: W: non-standard-dir-in-var empty opensmtpd.x86_64: E: use-old-pam-stack /etc/pam.d/smtp.opensmtpd (line 2) 2 packages and 0 specfiles checked; 5 errors, 18 warnings. # echo 'rpmlint-done:' Requires -------- opensmtpd-sysvinit (rpmlib, GLIBC filtered): /bin/bash /bin/sh /sbin/chkconfig /sbin/service opensmtpd opensmtpd (rpmlib, GLIBC filtered): /bin/sh chkconfig config(opensmtpd) libc.so.6()(64bit) libcrypt.so.1()(64bit) libcrypto.so.10()(64bit) libcrypto.so.10(OPENSSL_1.0.1)(64bit) libcrypto.so.10(OPENSSL_1.0.1_EC)(64bit) libcrypto.so.10(libcrypto.so.10)(64bit) libdb-4.8.so()(64bit) libdl.so.2()(64bit) libevent-2.0.so.5()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libresolv.so.2()(64bit) libssl.so.10()(64bit) libssl.so.10(libssl.so.10)(64bit) libz.so.1()(64bit) rtld(GNU_HASH) shadow-utils systemd Provides -------- opensmtpd-sysvinit: opensmtpd-sysvinit opensmtpd: MTA config(opensmtpd) opensmtpd opensmtpd(x86-64) server(smtp) smtpd smtpdaemon AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: opensmtpd-201311182347p1/configure.ac:31 Source checksums ---------------- Using local file /home/fedora/kevin/opensmtpd/opensmtpd.init as upstream file:///home/fedora/kevin/opensmtpd/opensmtpd.init : CHECKSUM(SHA256) this package : c13f52bcc1fab307030ce79dbe0e2642fbc2eb810493a122605d9d4e3af2351d CHECKSUM(SHA256) upstream package : c13f52bcc1fab307030ce79dbe0e2642fbc2eb810493a122605d9d4e3af2351d Using local file /home/fedora/kevin/opensmtpd/opensmtpd.pam as upstream file:///home/fedora/kevin/opensmtpd/opensmtpd.pam : CHECKSUM(SHA256) this package : 86aac59ff45d1e8d84791e1635daf24d20fbf4f4c30b6e99a2ca27c6a098f135 CHECKSUM(SHA256) upstream package : 86aac59ff45d1e8d84791e1635daf24d20fbf4f4c30b6e99a2ca27c6a098f135 http://www.opensmtpd.org/archives/opensmtpd-201311182347p1.tar.gz : CHECKSUM(SHA256) this package : 82619db15c2c0d77793c9bb7d0640ddfac634e1c05bda9bd2f8cb7365a4bdef0 CHECKSUM(SHA256) upstream package : 82619db15c2c0d77793c9bb7d0640ddfac634e1c05bda9bd2f8cb7365a4bdef0 Using local file /home/fedora/kevin/opensmtpd/opensmtpd.service as upstream file:///home/fedora/kevin/opensmtpd/opensmtpd.service : CHECKSUM(SHA256) this package : eea4f1eeb2958cbc052cf3f41dd2979856bcde689f9adcb70c77f6569e28f27d CHECKSUM(SHA256) upstream package : eea4f1eeb2958cbc052cf3f41dd2979856bcde689f9adcb70c77f6569e28f27d Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -n opensmtpd Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review