https://bugzilla.redhat.com/show_bug.cgi?id=1005522 Shakthi Kannan <shakthimaan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED Flags|fedora-review? |fedora-review+ --- Comment #4 from Shakthi Kannan <shakthimaan@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 983040 bytes in 100 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1054720 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ghc-mtl-2.1.2-26.fc19.x86_64.rpm ghc-mtl-devel-2.1.2-26.fc19.x86_64.rpm ghc-mtl-2.1.2-26.fc19.src.rpm ghc-mtl.x86_64: W: spelling-error Summary(en_US) Monad -> Mona, Gonad, Mon ad ghc-mtl.x86_64: W: spelling-error %description -l en_US Monad -> Mona, Gonad, Mon ad ghc-mtl.x86_64: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona ghc-mtl.x86_64: W: spelling-error %description -l en_US http -> HTTP ghc-mtl.x86_64: W: spelling-error %description -l en_US cecs -> ceca, secs, pecs ghc-mtl.x86_64: W: spelling-error %description -l en_US pdx -> pd, pix, pox ghc-mtl.x86_64: W: spelling-error %description -l en_US edu -> ed, educ, due ghc-mtl.x86_64: W: spelling-error %description -l en_US mpj -> mph, mp, mpg ghc-mtl.x86_64: W: spelling-error %description -l en_US springschool -> spring school, spring-school, schooling ghc-mtl.x86_64: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml ghc-mtl.src: W: spelling-error Summary(en_US) Monad -> Mona, Gonad, Mon ad ghc-mtl.src: W: spelling-error %description -l en_US Monad -> Mona, Gonad, Mon ad ghc-mtl.src: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona ghc-mtl.src: W: spelling-error %description -l en_US http -> HTTP ghc-mtl.src: W: spelling-error %description -l en_US cecs -> ceca, secs, pecs ghc-mtl.src: W: spelling-error %description -l en_US pdx -> pd, pix, pox ghc-mtl.src: W: spelling-error %description -l en_US edu -> ed, educ, due ghc-mtl.src: W: spelling-error %description -l en_US mpj -> mph, mp, mpg ghc-mtl.src: W: spelling-error %description -l en_US springschool -> spring school, spring-school, schooling ghc-mtl.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml 3 packages and 0 specfiles checked; 0 errors, 20 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint ghc-mtl ghc-mtl-devel ghc-mtl.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/ghc-7.4.2/mtl-2.1.2/libHSmtl-2.1.2-ghc7.4.2.so ['/builddir/build/BUILD/haskell-platform-2012.4.0.0/packages/transformers-0.3.0.0/dist/build', '/usr/lib64/ghc-7.4.2/base-4.5.1.0', '/usr/lib64/ghc-7.4.2/integer-gmp-0.4.0.0', '/usr/lib64/ghc-7.4.2/ghc-prim-0.2.0.0', '/usr/lib64/ghc-7.4.2'] 2 packages and 0 specfiles checked; 1 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- ghc-mtl (rpmlib, GLIBC filtered): ghc(base-4.5.1.0-6e4c9bdc36eeb9121f27ccbbcb62e3f3) ghc(transformers-0.3.0.0-8e66ecc7d4dae2b07b2b5406908c70e4) libHSbase-4.5.1.0-ghc7.4.2.so()(64bit) libHSghc-prim-0.2.0.0-ghc7.4.2.so()(64bit) libHSinteger-gmp-0.4.0.0-ghc7.4.2.so()(64bit) libHStransformers-0.3.0.0-ghc7.4.2.so()(64bit) libc.so.6()(64bit) libgmp.so.10()(64bit) rtld(GNU_HASH) ghc-mtl-devel (rpmlib, GLIBC filtered): /bin/sh ghc(mtl-2.1.2-02e701f9b1590ee88a0b5b0bd5d93a29) ghc-compiler ghc-devel(base-4.5.1.0-6e4c9bdc36eeb9121f27ccbbcb62e3f3) ghc-devel(transformers-0.3.0.0-8e66ecc7d4dae2b07b2b5406908c70e4) ghc-mtl(x86-64) Provides -------- ghc-mtl: ghc(mtl-2.1.2-02e701f9b1590ee88a0b5b0bd5d93a29) ghc-mtl ghc-mtl(x86-64) libHSmtl-2.1.2-ghc7.4.2.so()(64bit) ghc-mtl-devel: ghc-devel(mtl-2.1.2-02e701f9b1590ee88a0b5b0bd5d93a29) ghc-mtl-devel ghc-mtl-devel(x86-64) ghc-mtl-static Unversioned so-files -------------------- ghc-mtl: /usr/lib64/ghc-7.4.2/mtl-2.1.2/libHSmtl-2.1.2-ghc7.4.2.so Source checksums ---------------- http://hackage.haskell.org/packages/archive/mtl/2.1.2/mtl-2.1.2.tar.gz : CHECKSUM(SHA256) this package : 8c775764333420a4391823f9cb9b640306a262552280ea9bbdd2ca11194a8bef CHECKSUM(SHA256) upstream package : 8c775764333420a4391823f9cb9b640306a262552280ea9bbdd2ca11194a8bef Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1005522 Buildroot used: fedora-19-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG Successful Koji builds for F18, F19, and F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6241121 http://koji.fedoraproject.org/koji/taskinfo?taskID=6241122 http://koji.fedoraproject.org/koji/taskinfo?taskID=6241120 -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review