https://bugzilla.redhat.com/show_bug.cgi?id=1032108 --- Comment #40 from Kevin Kofler <kevin@xxxxxxxxxxxxxxxx> --- > %{_datadir}/icons/hicolor/16x16/apps/application-x-yarock.png > %{_datadir}/icons/hicolor/32x32/apps/application-x-yarock.png > %{_datadir}/icons/hicolor/48x48/apps/application-x-yarock.png > %{_datadir}/icons/hicolor/64x64/apps/application-x-yarock.png > %{_datadir}/icons/hicolor/128x128/apps/application-x-yarock.png I agree with Rex Dieter (comment #11) there. Enumerating every single icon (and even every single size!) explicitly is totally pointless. It will just fail the build for no reason when upstream adds new icons. I disagree with Terje's comment #12 here: > I want control over shipped files, changes should trigger a failed build. > > Control is more important than convenience for the packager. It really makes no sense to fail the build on new added icons. It is normal for applications to ship multiple icons: an application icon, a MIME type icon, custom actions not covered by the icon themes etc. There is no reason to require manually editing the specfile each time one is added. The use of globs is at the packager's discretion. As long as the directory ownership is correct (i.e. you MUST NOT use something like /* which ends up owning /usr, of course!), there is no guideline that forbids using globs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review