https://bugzilla.redhat.com/show_bug.cgi?id=1035935 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- I tried to package it about a year ago. And this spec you created is more like just a copy-and-paste from SUSE. Inital thoughts based on my version: 1. %define --> %global 2. Please move these: %define mirrorbrain_user mirrorbrain %define mirrorbrain_group mirrorbrain %define apxs /usr/sbin/apxs BuildRequires: httpd-devel BuildRequires: geoip geoip-devel mod_form BuildRequires: python-devel %define apache apache %define apache_libexecdir %(%{apxs} -q LIBEXECDIR) %define apache_sysconfdir %(%{apxs} -q SYSCONFDIR) %define apache_includedir %(%{apxs} -q INCLUDEDIR) %define apache_serverroot %(%{apxs} -q PREFIX) %define apache_localstatedir %(%{apxs} -q LOCALSTATEDIR) below the Source: http://mirrorbrain.org/files/releases/mirrorbrain-%{version}.tar.gz 3. Please remove BuildRoot/rm -rf $RPM_BUILD_ROOT/%clean 4. %postun %_postun_userdel %{mirrorbrain_user} Well, please read: https://fedoraproject.org/wiki/Packaging:UsersAndGroups?rd=Packaging/UsersAndGroups#Allocation_Strategies 5. Remove %{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(True)")} 6. Remove all Autoreqprov: on 7. install with -p to preserve the timestamp. 8. Release: 1 is invalid. 9. Mix using {buildroot} and $RPM_BUILD_ROOT, please consolidate 10.Requires: perl-Config-IniFiles Requires: perl-libwww-perl Requires: perl-Digest-MD4 Requires: perl-DBD-Pg Requires: perl-TimeDate Invalid, please see https://fedoraproject.org/wiki/Packaging:Perl#Perl_Requires_and_Provides -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review