https://bugzilla.redhat.com/show_bug.cgi?id=1032186 --- Comment #7 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Thanks for the suggestions. I've fixed all of them except the strange-permission error in rpmlint. I did change it from 775 to 755, but rpmlint is still unhappy that the permissions are not 644. To me it makes sense to keep the script executable. * Thu Nov 28 2013 Ken Dreyer <ktdreyer@xxxxxxxxxxxx> - 1.4.1-2 - Address issues from package review (RHBZ #1032186) - Correct comment about LICENSE - Unpack the tests tarball during %%setup - Use "set -e" in tests tarball generation script - Clean up zip file in tests tarball generation script Exact changes in Git: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-rack-openid.git/commit/?id=ca565b5b5a4322bcb8df6ae616055feb7cf46db6 Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-rack-openid.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-rack-openid-1.4.1-2.fc21.src.rpm F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6235787 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review