https://bugzilla.redhat.com/show_bug.cgi?id=1027784 --- Comment #6 from David King <amigadave@xxxxxxxxxxxxx> --- (In reply to Igor Gnatenko from comment #4) > Some issues has present. Fix it ;) Thanks for the review. > Issues: > ======= > - Package uses either %{buildroot} or $RPM_BUILD_ROOT > Note: Using both %{buildroot} and $RPM_BUILD_ROOT > See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros Fixed. The link is now https://fedoraproject.org/wiki/Packaging:Guidelines#Macros > Line 31: replacee $RPM_BUILD_ROOT to %{buildroot} > - For Changelog please use date in "07" or " 7" format > - You packaged not latest gnome-logs. Please update to 3.11.2 > - Use %make_install instead of make install DESTDIR="%{buildroot}" > - More better to move desktop-file-validate to %check section Fixed. > - Update icon cache in triggers > See: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Is this necessary? No icon is installed, although 3.11.3 will have an icon. > gnome-logs.x86_64: W: spelling-error Summary(en_US) systemd -> systems, > system, system d > gnome-logs.x86_64: W: spelling-error %description -l en_US systemd -> > systems, system, system d > gnome-logs.x86_64: W: no-manual-page-for-binary gnome-logs > gnome-logs.src: W: spelling-error Summary(en_US) systemd -> systems, system, > system d > gnome-logs.src: W: spelling-error %description -l en_US systemd -> systems, > system, system d > 2 packages and 0 specfiles checked; 0 errors, 5 warnings. These are not spelling errors. I have filed an upstream bug about a man page: https://bugzilla.gnome.org/show_bug.cgi?id=719485 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review