https://bugzilla.redhat.com/show_bug.cgi?id=1035425 --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. RPM can handle pkg-config well now. Please remove Requires: pkgconfig in -devel. 2. %define api 0.2 --> %global api 0.2 3. %dir %{_includedir}/%{name}-%{api} %{_includedir}/%{name}-%{api}/%{name} Oh? Why not just %{_includedir}/%{name}-%{api} 4. Since you've defined an api macro, according to GNOME software release habit, is it O to define version tag like this? Version: %{api}.1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review