https://bugzilla.redhat.com/show_bug.cgi?id=1015775 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |cickumqt@xxxxxxxxx Flags| |fedora-review? --- Comment #14 from Christopher Meng <cickumqt@xxxxxxxxx> --- Initial thoughts: 1. Summary should be "Arpspoof attacks protector", got from homepage. Also the description should be changed: TuxCut is a utility that protect linux computers againest arpspoof attacks Features: - Hide your machine (ip/MAC) from arp scanner utilities. - list all the live host in your LAN. - cut the connection between any live host and the gateway. - use wondershaper to limit your upload or download speed. You can notify them to remove that "(wondershaper not avaliable in fedora repos)." after bug 1018498 is closed. 2. Add a note at %build 3. cp -r --> cp -ar install -D -m --> install -pDm0644 4. Avoid using macro %{__mkdir_p} now, just mkdir -p is fine. 5. Remove %defattr(-,root,root,-) 6. No icon cache refresh script: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache 7. Ask upstream to provide sources tarball download at bitbucket(https://bitbucket.org/a_atalla/tuxcut/downloads). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review