[Bug 1032186] Review Request: rubygem-rack-openid - Provides a more HTTPish API around the ruby-openid library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1032186



--- Comment #5 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> ---
Thanks for taking the review.

I just realized that 1.4.1-1 contains a bad copy-and-paste from another gem.
This text:

  # Until upstream ships the full text of the ASL 2.0 in a released gem, we
will
  # ship the version from Git master.
  install -p -m 0644 %{SOURCE1} %{buildroot}%{gem_instdir}/LICENSE

needs to use %{SOURCE3} instead of %{SOURCE1}, and the comment needs to say
"MIT", rather than "ASL 2.0". Whoops! I can fix this after your full review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]