Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-YAML-Syck - Fast, lightweight YAML loader and dumper https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232018 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-03-26 00:03 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url ebb765d22bc14bddab4f86a5ade249d9 YAML-Syck-0.82.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t t/1-basic..............ok t/2-scalars............ok t/3-objects............ok t/4-perl_tag_scheme....ok t/json-basic...........ok t/json-circular-ref....ok t/json-empty...........ok t/json-indent..........ok t/json-minus...........ok t/json-newline.........ok t/json-null............ok t/json-refs............ok t/json-singlequote.....ok t/leak.................ok t/yaml-blessed-ref.....ok t/yaml-tie.............ok All tests successful. Files=16, Tests=200, 1 wallclock secs ( 0.82 cusr + 0.18 csys = 1.00 CPU) + Provides: Syck.so perl(JSON::Syck) perl(YAML::Dumper::Syck) perl(YAML::Loader::Syck) perl(YAML::Syck) = 0.82 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review