https://bugzilla.redhat.com/show_bug.cgi?id=786636 Ken Dreyer <ktdreyer@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ktdreyer@ktdreyer | |.com) | --- Comment #10 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> --- Hi Guillermo,I've made some adjustments to the spec file and pushed the changes to a Git repo, here: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-unicorn.git/log/ I've broken each change into a separate Git commit so you can review each one. I'll also try to explain each suggested change below. 1. use HTTPS in URL: This change changes the URL from using plaintext HTTP to secured HTTPS. 2. rm BuildRoot, %clean, and default defattr. There were a couple of older bits in the RPM that are not needed on EL6 and above. 3. adjust dist conditionals post F17. Since Fedora 17 is EOL, this commit removes references to it in the dist conditionals. 4. adjust whitespace. The Requires: ruby(release) field wasn't properly indented to align with the others, so this commit fixes that. 5. remove trailing whitespace. There was a lot of trailing whitespace in the spec file, so this commit fixes that. 6. update to 4.7.0. The upstream Unicorn project has released a new version this month, so I've updated the spec for this. 7. rm spurious dist tag conditional. There was an empty Fedora 18 dist tag conditional, and this commit removes it. 8. fix tests. This commit is a big one, and it might be a little controversial. It has two main changes: I've moved the test modifications to %prep, and I've changed the test invocation in %check to be simply "make test". 9. translate comment to english. This commit simply translates the comment about Unix permissions to english. 10. add comment about upstream fix for doc permissions. As it turns out the permissions problem was a bug in the wrongdoc gem. It was fixed upstream, so I contacted the Unicorn author and asked him to update to the lastest wrongdoc version. As it turns out, Eric was happy to do so, and the next version of Unicorn shouldn't have this permissions problem. I've added a link to the mailinglist discussion so that future maintainers will know "maybe this is fixed upstream and I can remove the chmod statement." 11. require rubygems in test helper. Since each of the tests load test_helper, it's simpler to require rubygems in the test helper rather than adding the rubygems line to each test file individually. 12. use simpler sed commands to fix shebang. So, this one might be a little controversial as well, but I think that it's simpler/cleaner to avoid grepping for upstream's strange shebang line and just use these sed functions instead. 13. build doc subpackage as noarch. The -doc subpackage should be set to "noarch" since there's no architecture-specific files within it. 14. filter test/doc files from auto-requires. If you look at the --requires on the -doc subpackage, you'll see that some weird things like /usr/bin/ruby, /bin/sh, /usr/bin/env get set. When we use the __requires_exclude_from macro, we can skip scanning the files that we ship in -doc. What do you think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review