[Bug 998469] Review Request: rubygem-unicode-display_width - Support for east_asian_width string widths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=998469



--- Comment #4 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
> - Please exclude Rakefile and .gemspec from the binary packages. See the next point...

??? Rakefile and .gemspec are not in main package, but in -doc package.

I put them there, because some developers find them useful. Because Rakefile
may be useful for developing and some developers wont to have original .gemspec
from upstream.

- Why not just remove everything during %prep for consistency? 

I cannot remove .yardoc in %prep, because it does not exist at that time. It is
generated during %build. And only if rubygem-yard is installed. Yard is not
present in koji (because it is not required), but if I do not remove it, then
local build for user may fail if he have yard instaled.

Anyway I replaced that 'rm' with %exclude if you think it is better.

And I addressed all other issues as well.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]