[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=912816



--- Comment #13 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
I suggest to disable the %check section for the time being so that I can do a
proper scratch build and approve your package, unless some other blocker issues
come up. This way we get the package at least into Rawhide and you might
re-enable the tests once kyua-cli has the right version. Well, we would have a
ping-pong-scenario similar to that one I already mentioned, but it would work
as long as both packages are available from the repos. Currently, with one repo
package and one which has to be scratch-built it wouldn't work. Is this
imagineable for you to do so?

BTW, instead of disabling the checks you could add a condition which makes it
more simple to switch them on and off:

%global with_checks 1

Then, in the %check section itself, you use the if/then constructs to
enable/disable it.

Moreover, you are using the %define macro. In most cases, %global is the better
choice. See
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]