Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: whysynth-dssi - DSSI software synthesizer plugin https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190029 opensource@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |opensource@xxxxxxxxx OtherBugsDependingO|163776 | nThis| | Flag| |fedora-review- ------- Additional Comments From opensource@xxxxxxxxx 2007-03-25 17:01 EST ------- rpmlint: W: whysynth-dssi dangling-relative-symlink /usr/bin/whysynth jack-dssi-host (can be ignored) E: whysynth-dssi non-standard-dir-perm /usr/share/doc/whysynth-dssi-20060122/doc 02755 (this should be fixed) naming: ok packaging guidelines: .desktop file: Categories=Application;AudioVideo;X-Synthesis;X-MIDI;X-Jack; Use Midi instead of X-MIDI and maybe add Audio to the categories. Also consider adding a GenericName entry to the .desktop file. See http://standards.freedesktop.org/menu-spec/latest/apa.html license: ok sources: ok 76e99ef8585345b03424b4770f896c0f whysynth-20060122.tar.bz2 76e99ef8585345b03424b4770f896c0f whysynth-20060122.tar.bz2.1 files and directories: see rpmlint mock build: ok Why do you install the icon twice? I think the icon below pixmaps can / should be skipped. btw. a nice alternative for this "(cd $RPM_BUILD_ROOT%{_bindir}; ln -s jack-dssi-host whysynth)" is: pushd $RPM_BUILD_ROOT%{_bindir} ln -s jack-dssi-host whysynth popd This makes it more clear, what you want to do here. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review