https://bugzilla.redhat.com/show_bug.cgi?id=1003301 --- Comment #3 from František Dvořák <valtri@xxxxxxxxxx> --- (In reply to Christopher Meng from comment #2) > Issues: > ======= > - Header files in -devel subpackage, if present. > Note: glite-lb-ws-interface : /usr/include/glite/lb/ws_interface_version.h > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages > > ------------>>>> > > I'm not familiar with glite itself, can you tell me the reason? > Basically, the whole glite-lb-ws-interface package is used as development package: for gLite L&B server and clients, so we haven't created -devel subpackage for the header. Most important are the WSDL files (Web Service interface) for generating stub in C and Java languages. The header file contains information about interface version for C programs compiled with glite-lb-ws-interface. > [!]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/include/glite/lb(glite-lb- > types), /usr/include/glite(glite-lbjp-common-gss-devel, glite-jobid- > api-c-devel, glite-lbjp-common-trio-devel, glite-lbjp-common-log-devel, > glite-lbjp-common-db-devel, glite-lb-types, glite-px-proxyrenewal-devel) > > ------------>>>> > Please fix. > There is problem the glite-lb-ws-interface package doesn't depend on the other packages, so the directory ownership is still needed, like in this case: http://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function > > ------------>>>> > > BuildRequires: libxslt > BuildRequires: perl > > Ah.. > > 1. Why not > > BuildRequires: libxslt-devel? > Only the xsltproc utility is needed during the build (for generating WSDLs from XML templates and for generating documentation). > > 2. BuildRequires: perl > > I think when you BR perl(POSIX) or perl(Getopt::Long) or any perl(XXX), perl > itself will be introduced automatically, so I think you can drop this line. The perl itself is called also from the spec file. See also review of glite-lb-types: https://bugzilla.redhat.com/show_bug.cgi?id=892597 . Thanks for taking the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review