[Bug 972650] Review Request: sugar-tuxmath - TuxMath is an arcade game that helps people practice their math facts.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=972650



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
1) See http://fedoraproject.org/wiki/Packaging:Python , you will find now its
recommended to use python2 not just python in macros 
so if you have python macro %{__python} change it to %{__python2}


2) This package failed to build because of wrong BR: sugar-toolkit-gtk3
You can identify what correct BR: you can use in your package spec by just
looking into setup.py file of upstream source

if it contains lines starting with following code
from sugar.activity 
this mean you should use BR: sugar-toolkit

if it contains lines starting with following code
from sugar3.activity 
this mean you should use BR: sugar-toolkit-gtk3

So, use correct BuildRequires: sugar-toolkit and this package will build fine.

3) also, this package uses bundled libraries which is not accepted in Fedora.
See
https://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries

Work with upstream to have this package built against system libraries.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]