[Bug 1032108] Review Request: Yarock - A Lightweight and Beautiful Qt Music Player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1032108



--- Comment #19 from James Abtahi <jamescategory@xxxxxxxxx> ---
> better to abide by the recommended guidelines:

> if e.g qt gets renamed to e.g qt5 you are in trouble, while with no explicit
> deps you are fine.

Ok, See what you mean. fixed.


> make %{?_smp_mflags} -C %{_target_platform} VERBOSE=1

> to see the difference. You will then see an other problem, correct build flags
> are not used.

I see the difference but I have a hard time spotting any issues during the
build time. The link you provided mention %{optflags}, shall I use that? What
are the correct build flags? The original developer does not mention anything
of that kind. I tried to use Rex's command to see what's going on in
%{optflags}:

> to see all the default options set, try:
> rpm --eval "%cmake"

Are the flags indicated by (rpm --eval %{optflags} ) the right one?

updated SPEC:
http://jam3s.fedorapeople.org/yarock.spec

updated Koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6214363

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]