https://bugzilla.redhat.com/show_bug.cgi?id=1032108 --- Comment #14 from james <jamescategory@xxxxxxxxx> --- > rpm should pick those up automatically (ie, if those libraries are linked into > the executbable). yes I know but better be safe than sorry ;) > add icons scriptlets, > and dependency on hicolor-icon-theme: Done. Although perhaps for those who are using KDE and other qt-based DE, this would be unnecessary. > fwiw, I disagree with a prior comment I wanted to discuss it with Terje Røsten but he seems to have a point. But I've seen many packages' SPECS (e.g. KDE's Konversation) in fedora that use the full glob and apparently nobody criticize them. I went through the pain of spelling out all those files so doesn't matter to argue now. > Use %{_prefix} for /usr. Done. > Important: proper updating of changelog, describe every change you did, > impossible to review without proper changelog. You're right, totally forget about that. fixed now. > Build is not verbose, not possible to verify build flags. What do you mean 'not verbose'? rpmbuild by default outputs the result in verbose mode. If you are interested in the output here you go: http://paste.fedoraproject.org/56032/13851251 > can you document what some of those problems were when you tried using %cmake macro? Well, I have to revert to previous SPECS to reproduce the errors again (I should have used git to keep track of file versions but I forgot). However I think you can reproduce it now with just replacing cmake line with %cmake .. and see what happens. Maybe it won't show those errors with the patch in place now. Believe me I messed with %cmake .. a lot and asked for a lot of help on irc channel. The use of cmake and that patch was the last resort. Anyway, here is the updated spec, let me know of further comments. The updated SPEC: http://jam3s.fedorapeople.org/yarock.spec Updated Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6213583 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review