[Bug 1032108] Review Request: Yarock - A Lightweight and Beautiful Qt Music Player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1032108



--- Comment #11 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
>  %{_datadir}/icons/hicolor/*/apps/application-x-yarock.png 

This is a new packager, please give them reasons/justifications to follow your
advice.  While that's a little better, being one line, I still don't see any
advantage to a full glob, 
%{_datadir}/icons/hicolor/*/*/*
For example, your suggestion will needlessly fail the build when/if upstream
includes scalable/svg icons.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]