https://bugzilla.redhat.com/show_bug.cgi?id=1032425 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL is usable. Ok. Source0 is usable. Ok. Source archive is orginal (SHA-256: 19a85b288778a6f223f77a2ce52a78e1b4c8e64596a01c9ece088b98c0e16cb0). Ok. No XS code, noarch BuildArch is Ok. Summary verified from lib/XML/Parser/Lite.pm. Ok. Description verified from lib/XML/Parser/Lite.pm. TODO: Fix grammar mistake `a interface'. License verified from README and lib/XML/Parser/Lite.pm. FIX: There is another license at lib/XML/Parser/Lite.pm:63: # The following code may be freely used and distributed provided that # this copyright and citation notice remains intact and that modifications # or additions are clearly identified. It does not look as any Fedora known license. I'm not sure if the `modifications or additions are clearly identified.' is compatible with GPL. FIX: The lib/XML/Parser/Lite.pm contains copyright for foreign module: # Copyright (C) 2000-2007 Paul Kulchenko (paulclinger@xxxxxxxxx) # Copyright (C) 2008 Martin Kutter (martin.kutter@xxxxxxxxxx) # SOAP::Lite is free software; you can redistribute it # and/or modify it under the same terms as Perl itself. This should get fixed. All tests pass. Ok. $ rpmlint perl-XML-Parser-Lite.spec ../SRPMS/perl-XML-Parser-Lite-0.717-1.fc21.src.rpm ../RPMS/noarch/perl-XML-Parser-Lite-0.717-1.fc21.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -qlvp ../RPMS/noarch/perl-XML-Parser-Lite-0.717-1.fc21.noarch.rpm drwxr-xr-x 2 root root 0 Nov 21 15:51 /usr/share/doc/perl-XML-Parser-Lite -rw-r--r-- 1 root root 121 May 16 2013 /usr/share/doc/perl-XML-Parser-Lite/Changes -rw-r--r-- 1 root root 1159 May 16 2013 /usr/share/doc/perl-XML-Parser-Lite/README -rw-r--r-- 1 root root 3354 Nov 21 15:51 /usr/share/man/man3/XML::Parser::Lite.3pm.gz drwxr-xr-x 2 root root 0 Nov 21 15:51 /usr/share/perl5/vendor_perl/XML drwxr-xr-x 2 root root 0 Nov 21 15:51 /usr/share/perl5/vendor_perl/XML/Parser -rw-r--r-- 1 root root 10771 May 16 2013 /usr/share/perl5/vendor_perl/XML/Parser/Lite.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-XML-Parser-Lite-0.717-1.fc21.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.18.1) 1 perl(re) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-XML-Parser-Lite-0.717-1.fc21.noarch.rpm | sort -f | uniq -c 1 perl(XML::Parser::Lite) = 0.717 1 perl-XML-Parser-Lite = 0.717-1.fc21 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-XML-Parser-Lite-0.717-1.fc21.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6209592). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide new SPEC file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review