Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rss2email - Deliver news from RSS feeds to your smtp server as text or html mail https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233715 ------- Additional Comments From fedora@xxxxxxxxxxxxx 2007-03-25 03:54 EST ------- Patrice, thx for looking over this. > there are 2 patches in the debian patcheset [...] Applied one of them; the others are non-obvious to me ATM, and I prefer to go without them for now. > the debian template file seems to be better than yours, with a lot > of comments, but you may disagree ;-) Yes, I want to avoid maintaining a copy of what is already documented and maintenanced in another place. I also dislike to have many comments that describe each option in config files, as that IMHO hurts badly when you have to merge older and new configurations, because you end up merging lots of changed comments over if you do it with diff/meld or similar tools. > I have some remarks on rss2email-r2e [...] Fixed > I suggest doing sed [...] on r2e. Done > dos2unix issue Fixed (stupid me) > remove / after $RPM_BUILD_ROOT Done. > I also suggest that you get in touch with the debian packager > to share your r2e script and your patch. Contacting upstream and the debian maintainer is the plan after I have been using it for some days first and see if everythings works as expected. * Updated package: Spec URL: http://www.leemhuis.info/files/fedorarpms/SPECS.fdr/rss2email.spec Spec diff URL: http://www.leemhuis.info/files/fedorarpms/DIFFS.fdr/rss2email.spec SRPM URL: http://www.leemhuis.info/files/fedorarpms/SRPMS.fdr/rss2email-2.60-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review