[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1032750



--- Comment #1 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> ---
1. The %{import_path} could be placed in Source0 as well if you wanna make it
shorter, but no biggie.

2. rm -rf $RPM_BUILD_ROOT lines should be removed (is it otherwise causing an
error on el6?) . Also, I remember you saying absence of %defattr complains on
el6, so leaving that in should be ok.

3. as per the prior packaged golang deps, we'd also need:
%dir %attr(755,root,root) %{gopath}/src/github.com
%dir %attr(755,root,root) %{gopath}/src/github.com/syndtr
..in addition to the already existing ones.

4. ls in %install is probably not needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]