https://bugzilla.redhat.com/show_bug.cgi?id=990423 --- Comment #16 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Jose Pedro Oliveira from comment #14) > %doc test/default/*.{c,h} Fine. > * Do we need to increase the verbosity level of make (V=1)? Yes, it's a MUST. > * Don't include the README file; the only one that matters is the > README.markdown Fine, dropped. > * The specfile doesn't build for EPEL6. See comment #c7 and > https://bugzilla.redhat.com/show_bug.cgi?id=1025972#c2 You've said that it has been merged upstream, so why didn't they release with the fix? > * Please add the ticket number to the changelog entry (in particular > when specfiles changes are driven by feedback posted on bugzilla tickets) Well, > +- Package the new pkgconfig file. 1. Upstream started to provide a pkgconfig file, not me, I don't think we need to say about that(unless libsodium is already included in Fedora, but still not reasonable) > +- Small specfile improvements (#990423). 2. This is OK. But I never do this. Because I need bodhi to send comments to bugs from the latest changelog. ------------------- Spec URL: http://cicku.me/libsodium.spec SRPM URL: http://cicku.me/libsodium-0.4.5-2.fc21.src.rpm PS if you want to take this review, please assign. -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review