https://bugzilla.redhat.com/show_bug.cgi?id=990423 --- Comment #14 from Jose Pedro Oliveira <jpo@xxxxxxxxxxxx> --- (In reply to Christopher Meng from comment #13) > (In reply to Jose Pedro Oliveira from comment #7) > > please add the test/default/*.c files > > (they can also serve as documentation) > > I think that just including .c is not enough, I see one core3.c requires > cmptest.h, so I want your idea again. You can also include the header file. Just add the following line %doc test/default/*.{c,h} > Except this, all fixed at: > > Spec URL: http://cicku.me/libsodium.spec > SRPM URL: http://cicku.me/libsodium-0.4.5-1.fc21.src.rpm * Do we need to increase the verbosity level of make (V=1)? * Don't include the README file; the only one that matters is the README.markdown * The specfile doesn't build for EPEL6. See comment #c7 and https://bugzilla.redhat.com/show_bug.cgi?id=1025972#c2 * Please add the ticket number to the changelog entry (in particular when specfiles changes are driven by feedback posted on bugzilla tickets) /jpo -- You are receiving this mail because: You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review