[Bug 1032108] Review Request: Yarock - A Lightweight and Beautiful Qt Music Player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1032108

Terje Røsten <terjeros@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |terjeros@xxxxxxxxxxxx



--- Comment #4 from Terje Røsten <terjeros@xxxxxxxxxxxx> ---
Quick comments:

 o remove empty lines
 o change 
   A lightweight, beautiful music player written in C++/Qt 
     to
   A lightweight, beautiful music player

  and ditto:

    Yarock is a music player designed to provide a clean,  
    simple and beautiful music collection based on album coverart.

 o cmake -DCMAKE_INSTALL_PREFIX:PATH=/usr ..
   use %cmake here.

 o remove 
   rm -rf %{buildroot} 
   in %install

 o remove:
   %clean
   rm -rf %{buildroot}

 o remove
   %defattr(-,root,root,-)

 o be more specific here:
   %{_datadir}/icons/hicolor/*/*/*


please provide koji scratch build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]