https://bugzilla.redhat.com/show_bug.cgi?id=1031342 --- Comment #12 from Xavier Bachelot <xavier@xxxxxxxxxxxx> --- (In reply to Rob Clark from comment #11) > (In reply to Xavier Bachelot from comment #7) > > - Swap the Summary: and Name: lines. > > just double checking, are you sure about that? What I have is at least > consistent with xorg-x11-drv-intel and xorg-x11-drv-{intel,nouveau,omap}? > > (not claiming to be an expert about this, but just trying to stay consistent > with the other ddx drivers) This is cosmetic only, not a blocker at all, I just felt it was more logical to have Name: before Summary:. And the other X driver specs are old, so they might not be the state of the art. The canonical form for the spec can be seen in /etc/rpmdevtools/spectemplate-minimal.spec but it seems even that is outdated, as there is still BuildRoot:, a %clean section, etc... Sorry for bringing confusion with my comments. To be clearer, the Name: and Summary: as well as the URL: changes are cosmetic, do as you see fit. The others needs to be fixed, but I let Christopher point out the real issues in the formal review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review