https://bugzilla.redhat.com/show_bug.cgi?id=1018498 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |cickumqt@xxxxxxxxx Flags| |fedora-review? --- Comment #6 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. URL should be: http://sourceforge.net/projects/wondershaper/ 2. Because nothing need to be built during %build, please add a note about this: %build # Nothing to build. 3. install -Dm 755 wshaper %{buildroot}/%{_sbindir}/%{name} --> install -pDm755 wshaper %{buildroot}%{_sbindir}/%{name} 4. %files %doc ChangeLog COPYING README VERSION I don't think you need to ship VERSION file... Others are fine. ------------------- Suggestion: In function show_help of this shell script, please consider this change: function show_help { echo "Wonder Shaper 1.2" echo echo "Usage: $0 [device] clean|[upload speed in Kb/s] [download speed in Kb/s]" echo "Example: $0 eth0 20 500" echo echo "Report bugs at http://bugzilla.redhat.com/."; exit } to function show_help { echo "Wonder Shaper 1.2" echo echo "Usage: $0 [device] clean|[upload speed in Kb/s] [download speed in Kb/s]" echo "Example: $0 eth0 20 500" echo echo "Report bugs at https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&version=rawhide&component=wondershaper."; exit } -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review