https://bugzilla.redhat.com/show_bug.cgi?id=1031437 --- Comment #3 from Gerard Ryan <gerard@xxxxxxx> --- Thanks for taking this review Gil! (In reply to gil cattaneo from comment #1) > main package must be like: > > %files -f .mfiles-%{name} > %dir %{_javadir}/%{name} > %doc epl-v10.html > > please, fix unowned directory > .mfiles should be empty, use .mfiles-%{name} instead if available > license should be preferred in text format > http://opensource.org/licenses/eclipse-1.0.txt > and available for every sub package Done. I copied the text from that license link into a new file since it contained probably more html than the epl-v10.html file. I also didn't include the URL that you mentioned for that reason (it's a different file now, just happens to have the same name). (In reply to gil cattaneo from comment #1) > [!]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. ... > [!]: Package does not include license text files separate from upstream. Since this is EPL, we must include it, so I'll consider these two as 'done' unless you disagree. > [!]: License file installed when any subpackage combination is installed. Done in 2.3.3-2 > [!]: Package requires other packages for directories it uses. > Note: No known owner of /usr/share/java/truecommons > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/java/truecommons Done in 2.3.3-2 > [!]: If the source package does not include license text(s) as a separate file > from upstream, the packager SHOULD query upstream to include it. Done: https://java.net/jira/browse/TRUECOMMONS-9 Spec URL: http://galileo.fedorapeople.org/truecommons/2.3.3-2/truecommons.spec SRPM URL: http://galileo.fedorapeople.org/truecommons/2.3.3-2/truecommons-2.3.3-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review