[Bug 1031527] Review Request: datefudge - fakes the system date/time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1031527



--- Comment #5 from Christopher Meng <cickumqt@xxxxxxxxx> ---
Ok.

So:

1. Remove these:

BuildRoot:    %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

rm -rf %{buildroot} in %install

Whole %clean

%defattr(-,root,root,-)

2. URL better use PTS page:

http://packages.qa.debian.org/d/datefudge.html

3. Source0 better use CDN:

http://cdn.debian.net/debian/pool/main/d/datefudge/datefudge_1.18.tar.gz

with macro replaced, too.

4. I checked your patch.

INSTALL_PROGRAM := "install" should also be patched to 

INSTALL_PROGRAM := "install -p"

5. $(CFLAGS) should be inserted with %{optflags}:

http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

You can define cflags like make CFLAGS="%{optflags}"

And $(LDFLAGS) also should be defined with %{__global_ldflags}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]