Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command Alias: ntop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=219025 ------- Additional Comments From pertusus@xxxxxxx 2007-03-24 21:59 EST ------- * ntop daemon is started by default, this is not right, Default-Start: should certainly be empty, instead of: # Default-Start: 3 4 5 * when I do export CFLAGS="%{optflags} -DDEBUG" just before %configure in %build, there is a compile error in util.c, so I cannot test a build with -DDEBUG. * the libraries aren't linked against any libraries, so there are a lot of undefined non weak symbols with rpmlint run on the installed rpm. I'll attach a patch. After applying the patch I get W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /usr/lib/librrd_th.so.2 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /usr/lib/libgdome.so.0 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /lib/libglib-2.0.so.0 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /usr/lib/libxml2.so.2 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /usr/lib/libgd.so.2 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /usr/lib/libpng12.so.0 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /lib/libssl.so.6 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /usr/lib/libnetsnmpmibs.so.15 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /usr/lib/libnetsnmphelpers.so.15 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /usr/lib/libsensors.so.3 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /lib/libresolv.so.2 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /lib/libnsl.so.1 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /lib/libcrypt.so.1 W: ntop unused-direct-shlib-dependency /usr/lib/libntop-3.3.so /lib/libutil.so.1 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /lib/libpcre.so.0 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /usr/lib/libgdome.so.0 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /lib/libglib-2.0.so.0 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /usr/lib/libxml2.so.2 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /usr/lib/libpng12.so.0 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /usr/lib/mysql/libmysqlclient_r.so.15 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /usr/lib/libnetsnmpmibs.so.15 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /usr/lib/libnetsnmphelpers.so.15 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /usr/lib/libnetsnmp.so.15 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /usr/lib/libsensors.so.3 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /usr/lib/perl5/5.8.8/i386-linux-thread-multi/CORE/libperl.so W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /lib/libresolv.so.2 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /lib/libnsl.so.1 W: ntop unused-direct-shlib-dependency /usr/lib/libntopreport-3.3.so /lib/libutil.so.1 It means that there should be more fine grained linking flags added in *_LIBADD, *_LDADD. There are still some non-weak symbols: W: ntop undefined-non-weak-symbol /usr/lib/libntop-3.3.so welcome W: ntop undefined-non-weak-symbol /usr/lib/libntop-3.3.so static_ntop W: ntop undefined-non-weak-symbol /usr/lib/libntop-3.3.so welcome W: ntop undefined-non-weak-symbol /usr/lib/libntop-3.3.so setAdminPassword W: ntop undefined-non-weak-symbol /usr/lib/libntop-3.3.so usage W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so welcome W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so static_ntop W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so welcome W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so setAdminPassword W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so usage W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so addUser W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so changeFilter W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so doAddUser W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so doChangeFilter W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so showUsers W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so addURL W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so deleteUser W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so doAddURL W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so addDefaultAdminUser W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so handleNtopConfig W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so showURLs W: ntop undefined-non-weak-symbol /usr/lib/libntopreport-3.3.so deleteURL I checked some of those symbols, they were in admin.c, or main.c and admin.c and main.c are only in ntop. This should really be reported upstream, this is weird.... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review