[Bug 1031400] Review Request: php-symfony2-icu - Symfony2 Icu Component

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1031400



--- Comment #4 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
[!] Package installs properly.
    Wait for dependency before import
[~]: Package is named according to the Package Naming Guidelines.
    could be php-symfony-icu, but 2 is acceptable.
[~]: Latest version is packaged.
    1.1 for EPEL-6, 1.2 for Fedora => ok.
[~]: %check is present and all tests pass.
    intl not yet available
    I would have prefer to have test disabled, but... ok
[!]: All build dependencies are listed in BuildRequires...
    => BuildRequires: libicu >= %{libicu_min_ver}
    so you can drop the pkgconfig stuff.
[!]: Requires correct, justified where necessary.
    => Requires: libicu >= %{libicu_min_ver}
    libicu is already pulled by php-intl, so this is only for version check


So only need to fix the libicu requirement (simpler), and wait for
php-symfony2-intl approval before import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]