[Bug 518317] Review Request: perdition - Mail Retrieval Proxy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=518317



--- Comment #34 from Christopher Meng <cickumqt@xxxxxxxxx> ---
(In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #32)
> %{_sysconfdir}/%{name} mentioned as %dir now and files listed separately.
> Meantime i have not seen such error in rpmlint out. How you catch it?

Well, fedora-review does warn about it...

> > [!]: Package must own all directories that it creates.
> >      Note: Directories without known owners: /etc/rc.d/init.d, /etc/rc.d,
> >      /etc/openldap/schema
> It is not perdition directories:
> # repoquery --whatprovides /etc/rc.d/init.d /etc/rc.d/init.d
> /etc/rc.d/init.d | sort -u
> chkconfig-0:1.3.60-3.fc19.x86_64
> initscripts-0:9.47-1.fc19.x86_64

Should be false positives.

> > [!]: Package is named according to the Package Naming Guidelines.
> Sorry, what the problem with package name?

Ah my bad...I made many mistakes yesterday...Sorry.

> > [!]: Package complies to the Packaging Guidelines

Well, complying with guidelines means no errors found.(not sure lol)

> > [!]: Package should not use obsolete m4 macros
> >      Note: Some obsoleted macros found, see the attachment.
> >      See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
> I think it is not big issue.

Yes, but please report upstream.

> perdition-sysvinit.noarch: E: no-chkconfig-line /etc/rc.d/init.d/perdition
> 
> which come from fact package provide several services from one package.

I just read the init file, it's using LSB headers, so no problem here. I will
write a patch for rpmlint later.

------
perdition.i686: E: non-readable /usr/lib/systemd/system/perdition-pop3s.service
0600L
perdition.i686: E: non-readable
/usr/lib/systemd/system/perdition-managesieve.service 0600L
perdition.i686: E: non-readable /usr/lib/systemd/system/perdition-imap4.service
0600L
perdition.i686: E: non-readable /usr/lib/systemd/system/perdition-pop3.service
0600L
perdition.i686: E: non-readable
/usr/lib/systemd/system/perdition-imap4s.service 0600L


install -Dm 600 %{name}-$service.service
%{buildroot}/%{_unitdir}/%{name}-$service.service

Should be 644.

------

perdition.i686: E: zero-length /usr/share/doc/perdition/NEWS

Drop it.

--------------------

Fix above will be ready for approval.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]