[Bug 518317] Review Request: perdition - Mail Retrieval Proxy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=518317



--- Comment #32 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> ---
(In reply to Christopher Meng from comment #31)
> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> 
> 
> Issues:
> =======
> - Package does not contain duplicates in %files.
>   Note: warning: File listed twice: /etc/perdition/Makefile
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

%{_sysconfdir}/%{name} mentioned as %dir now and files listed separately.
Meantime i have not seen such error in rpmlint out. How you catch it?

> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /etc/rc.d/init.d, /etc/rc.d,
>      /etc/openldap/schema
It is not perdition directories:
# repoquery --whatprovides /etc/rc.d/init.d /etc/rc.d/init.d /etc/rc.d/init.d |
sort -u
chkconfig-0:1.3.60-3.fc19.x86_64
initscripts-0:9.47-1.fc19.x86_64

They listed in sysvinit subpackage dependencies as per doc
https://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_addition_to_systemd_unit_files

> [!]: Package is named according to the Package Naming Guidelines.
Sorry, what the problem with package name?

> [!]: Package complies to the Packaging Guidelines
Please be more precise.

> ===== EXTRA items =====
> 
> Generic:
> [!]: Package should not use obsolete m4 macros
>      Note: Some obsoleted macros found, see the attachment.
>      See: https://fedorahosted.org/FedoraReview/wiki/AutoTools
I think it is not big issue.

> [x]: Rpmlint is run on all installed packages.
>      Note: There are rpmlint messages (see attachment).
Most of them are spelling errors or incorrect directory permissions which I
can't fix. There also few false positives like:
perdition-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/perdition
perdition.pop3
perdition-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/perdition
perdition.pop3s
perdition-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/perdition
perdition.imap4
perdition-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/perdition
perdition.imaps
perdition-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/perdition
perdition.managesieve
perdition-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/perdition
perdition.pop3
perdition-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/perdition
perdition.pop3s
perdition-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/perdition
perdition.imap4
perdition-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/perdition
perdition.imaps
perdition-sysvinit.noarch: E: incoherent-subsys /etc/rc.d/init.d/perdition
perdition.managesieve
perdition-sysvinit.noarch: E: no-chkconfig-line /etc/rc.d/init.d/perdition

which come from fact package provide several services from one package.


New package with most fixes (see below):
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6190586
Changes:
https://github.com/Hubbitus/Fedora-packaging/commit/ee676e51ea15ba3a25fe2a3294eefd8f3b307810
Spec:
https://raw.github.com/Hubbitus/Fedora-packaging/ee676e51ea15ba3a25fe2a3294eefd8f3b307810/SPECS/perdition.spec
Srpm: http://hubbitus.info/rpm/Fedora19/perdition/perdition-2.0-3.fc19.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]