https://bugzilla.redhat.com/show_bug.cgi?id=916039 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Flags| |fedora-review? --- Comment #8 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- The latest updates in the Python packaging guidelines need the following changes: python-devel > python2-devel %{__python} > %{__python2} Besides that, %{python2_sitelib} is also available as macro (currently not for EPEL), although not mentioned in the packaging guidelines yet. The source tarball contains a manpage named "albumart-qt.1" in the "debian" folder. Please install it. The folder %{_datadir}/apps/konqueror/servicemenus/ is owned by the kde-filesystem-package. You still have to add it to "Requires:". I suggest to create a -konqueror subpackage to make your main package independent from KDE. The subpackage should also require kde-baseapps where the "konqueror" binary resides. Without that, it wouldn't make sense to have such a servicemenu. Moreover, have a look at the Provides in the binary package. I'm not sure if PyQt will detected automatically by rpm. If not, add it manually. Most of the file headers of the Python scripts don't show licenses, but at least one file which will go in the binary package has the "later versions" clause in addition to the GPLv2 declaration, that's why the package license is GPLv2+. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review