Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rss2email - Deliver news from RSS feeds to your smtp server as text or html mail https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233715 ------- Additional Comments From pertusus@xxxxxxx 2007-03-24 13:41 EST ------- * there are 2 patches in the debian patcheset, one for html2txt and one for rss2email that may be relevant. * Maybe you could ask the debian maintainer to avoid directly patching the sources, but instead put all the debian patches below debian/ such that you can apply the debian patcheset and use the patches and files directly. * the debian template file seems to be better than yours, with a lot of comments, but you may disagree ;-) * I have some remarks on rss2email-r2e: I may be wrong, but it seems to me that [[ ]] is not an sh feature. Also = in conditional is more portable than ==. I can make a patch if you like. * I suggest doing sed -e -i 's;/usr/share;%{_datadir}/g' on r2e. * dos2unix issue * suggestion: remove / after $RPM_BUILD_ROOT * I also suggest that you get in touch with the debian packager to share your r2e script and your patch. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review