https://bugzilla.redhat.com/show_bug.cgi?id=1028741 David Tardon <dtardon@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #10 from David Tardon <dtardon@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - update-desktop-database is invoked when required Note: desktop file(s) in engauge-digitizer See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in engauge- digitizer-data , engauge-digitizer-transpose [x]: Package complies to the Packaging Guidelines [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL (v2 or later)", "Unknown or generated". 3 files have unknown license. Detailed output of licensecheck in /home/dtardon/work/rpm/1028741-engauge-digitizer/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked when required Note: icons in engauge-digitizer [x]: Useful -debuginfo package or justification otherwise. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 61440 bytes in 6 files. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: engauge-digitizer-5.2-3.fc18.x86_64.rpm engauge-digitizer-data-5.2-3.fc18.noarch.rpm engauge-digitizer-transpose-5.2-3.fc18.x86_64.rpm engauge-digitizer.x86_64: E: incorrect-fsf-address /usr/share/doc/engauge-digitizer-5.2/LICENSE engauge-digitizer.x86_64: W: no-manual-page-for-binary engauge engauge-digitizer.x86_64: W: desktopfile-without-binary /usr/share/applications/engauge-digitizer.desktop env engauge-digitizer-data.noarch: W: no-documentation engauge-digitizer-transpose.x86_64: E: incorrect-fsf-address /usr/share/doc/engauge-digitizer-transpose-5.2/LICENSE engauge-digitizer-transpose.x86_64: W: no-manual-page-for-binary transpose 3 packages and 0 specfiles checked; 2 errors, 4 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint engauge-digitizer engauge-digitizer-data engauge-d igitizer-transpose engauge-digitizer.x86_64: E: incorrect-fsf-address /usr/share/doc/engauge-digitizer-5.2/LICENSE engauge-digitizer.x86_64: W: no-manual-page-for-binary engauge engauge-digitizer-data.noarch: W: no-documentation engauge-digitizer-transpose.x86_64: E: incorrect-fsf-address /usr/share/doc/engauge-digitizer-transpose-5.2/LICENSE engauge-digitizer-transpose.x86_64: W: no-manual-page-for-binary transpose 3 packages and 0 specfiles checked; 2 errors, 3 warnings. # echo 'rpmlint-done:' Requires -------- engauge-digitizer (rpmlib, GLIBC filtered): /bin/sh engauge-digitizer-data libQt3Support.so.4()(64bit) libQtCore.so.4()(64bit) libQtGui.so.4()(64bit) libQtNetwork.so.4()(64bit) libc.so.6()(64bit) libfftw3.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) engauge-digitizer-data (rpmlib, GLIBC filtered): engauge-digitizer-transpose (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libXext.so.6()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libqt-mt.so.3()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- engauge-digitizer: engauge-digitizer engauge-digitizer(x86-64) engauge-digitizer-data: engauge-digitizer-data engauge-digitizer-transpose: engauge-digitizer-transpose engauge-digitizer-transpose(x86-64) Source checksums ---------------- http://sourceforge.net/projects/digitizer/files/Engauge Digitizer/digitizer-5.2/engauge_5.2.tgz : CHECKSUM(SHA256) this package : 2defe5f06a78cbb9e3361e649de6b84b90fa85e3f587245e240b8efb8df78b36 CHECKSUM(SHA256) upstream package : 2defe5f06a78cbb9e3361e649de6b84b90fa85e3f587245e240b8efb8df78b36 Generated by fedora-review 0.4.1 (b2e211f) last change: 2013-04-29 Buildroot used: fedora-18-x86_64 Command line :/usr/bin/fedora-review -b 1028741 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review