Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: openobex https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226215 ------- Additional Comments From ville.skytta@xxxxxx 2007-03-24 10:56 EST ------- Created an attachment (id=150826) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=150826&action=view) Fix pkgconfig path on lib64 archs - libusb.pc is searched from a wrong dir on lib64 archs by configure (see patch), resulting in missing "Requires: libusb" from the .pc file - BuildRequires and ExcludeArch for -apps seem to be dupes, they're already in the main package - autoreconf would be better placed in %prep - configuring with --disable-dependency-tracking would clean up the build output and possibly speed the build up a bit - Summaries and descriptions could be improved quite a bit. The description for -devel is actually wrong. - make -C doc does not actually seem to build anything, and (unsurprisingly) its results aren't included in any subpackages. Perhaps build the HTML doc (make -C doc html) and include it in -devel, or don't build any of the docs, and drop the make -C doc as well as docbook related build dependencies? - Including all AUTHORS etc %docs in all subpackages doesn't look too useful, perhaps drop them altogether from -apps and -devel since they require the main package anyway and seem to contain only generic info about the software which is probably best kept in the main package? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review