[Bug 1019453] Review Request: sddm-kcm - SDDM KDE configuration module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1019453

Rex Dieter <rdieter@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |rdieter@xxxxxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #4 from Rex Dieter <rdieter@xxxxxxxxxxxx> ---
License: ok

1. Naming: mostly ok, please do reset to Version: 0 per comment #2

macros: ok

2. scriptlets: mostly ok, there's an extranous

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

which is not needed, please remove.


The reset is clean and simple, APPROVED.


please address items 1,2 prior to doing any official builds.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]