https://bugzilla.redhat.com/show_bug.cgi?id=1027770 --- Comment #32 from Alec Leamas <leamas.alec@xxxxxxxxx> --- Oops, you are such such a resourceful person I forget that this is your first package. A somewhat easier way is something like; Source4: PACKAGE-LICENSING %install cp -a %{SOURCE4} PACKAGE-LICENSING %files %doc PACKAGE-LICENSING There is really no need to install in a subdirectory, %doc fixes that. BTW, don't hesitate to ask here or on the list before spending too much time on such things! Basically I think the license now looks good. Time for some nitpicks before doing the review: - You need to claim the /etc/ocserv dir. Add a %dir %{_sysconfdir}/ocserv to %files. - With gnutls-devel at 3.1.16 for f19, what's the point requiring > 3.1.10? - ccan files are bundled, we must wait for FPC (meeting Thursday 16.00 UTC). Add a note in the spec for now. - The "normal" way is to run autoreconf -fi. Is there a particular reason why you omit the -fi options? - You forgot the changelog last time. While not that important during review, it's essential once committed. So I nag about it. Some style remarks. These are preferences, don't consider them as review remarks: - Some lines are really long, too long in my eyes. Comments are easy to split, One can have multiple %doc lines. A long link is a long link, though. - Having one BR on each line makes it clearer, sorting them is even better. - One extra blank line before main sections (%description, %prep, %install, scriptlets, %files, %changelog) enhances readability. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review