[Bug 226140] Merge Review: microcode_ctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=226140

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |anton@xxxxxxxxxx,
                   |                            |panemade@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Anton,
  I see from changelog you did some few updates. So here I am suggesting some
changes in spec that are required as per current packaging guidelines.

1) Group and Buildroot tag is not needed now. Remove those lines.

2) removal of buildroot in %install not needed
rm -rf %{buildroot}

3) %clean is not needed

4) make command and your %files section should use macros. Below is %files
section 
%files
%{_sbindir}/intel-microcode2ucode
/%{_lib}/firmware/*
%doc /usr/share/doc/microcode_ctl/*

5) rpmlint on rpms show
microcode_ctl.x86_64: W: summary-ended-with-dot C Tool to transform and deploy
CPU microcode update for x86.
=> remove ending dot in summary

fix above issues. Build new package in master.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]