https://bugzilla.redhat.com/show_bug.cgi?id=1025977 --- Comment #12 from Michele Baldessari <michele@xxxxxxxxxx> --- Hi Mikolaj, (In reply to Mikolaj Izdebski from comment #11) > (In reply to Michele Baldessari from comment #10) > > > chmod calls in %install should be avoided, please use %attr macro in %files > > > section instead. > > > > Ack, done. Although without chmod in install I need to be more verbose in the > > %files section. (i.e. To avoid a file being listed twice I need to list > > files or directories explicitely). Not sure if there is a clever way around > > that? > > There is no harm in listing files more then once. RPM will print a warning, > but it can be ignored in most cases. (If you really wanted to exclude some > files then you could use %exclude macro, but it is not needed in this case.) Ah ok, good to know. > But first I would think if "chmod" or "%attr" is really needed and why. If > "make install" does not install files marked as executable then it's > probably upstream bug. If that's the case then you should report it. Once > it's fixed you'll be able to remove %attr macro. Yes, I've chased this option as it makes the spec a bit cleaner and sent the one-liner upstream. Once I get the feedback about the licensing questions, I'll submit the latest round of spec+srpm Thanks and regards, Michele -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review