https://bugzilla.redhat.com/show_bug.cgi?id=1026743 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Elasticsearch.spec.old 2013-11-08 15:35:19.000000000 +0100 +++ perl-Elasticsearch.spec 2013-11-11 11:01:39.000000000 +0100 @@ -1,6 +1,6 @@ Name: perl-Elasticsearch Version: 0.75 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Official client for Elasticsearch License: ASL 2.0 @@ -41,9 +41,15 @@ BuildRequires: perl(Try::Tiny) BuildRequires: perl(URI) BuildRequires: perl(YAML) + +Requires: perl(IO::Socket::SSL) +Requires: perl(IO::Uncompress::Inflate) +Requires: perl(MIME::Base64) Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %{?perl_default_filter} +%global __requires_exclude perl\\(VMS|perl\\(Win32|perl\\(HTTP::Tiny\\)$ +%global __requires_exclude perl\\(VMS|perl\\(Win32|perl\\(Moo\\)$ %description Elasticsearch is the official Perl client for Elasticsearch. Elasticsearch @@ -62,6 +68,7 @@ make pure_install DESTDIR=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; +find $RPM_BUILD_ROOT -type f -name bench_cxn.pl -exec rm -f {} \; %{_fixperms} $RPM_BUILD_ROOT/* @@ -74,6 +81,9 @@ %{_mandir}/man3/* %changelog +* Mon Nov 11 2013 Emmanuel Seyman <emmanuel@xxxxxxxxx> - 0.75-3 +- Take more comments from the review into account (#1026743) + * Fri Nov 08 2013 Emmanuel Seyman <emmanuel@xxxxxxxxx> - 0.75-2 - Take package review into account (#1026743) $ rpmlint perl-Elasticsearch.spec ../SRPMS/perl-Elasticsearch-0.75-3.fc21.src.rpm ../RPMS/noarch/perl-Elasticsearch-0.75-3.fc21.noarch.rpm perl-Elasticsearch.src: W: spelling-error %description -l en_US analytics -> analytic, analytic s, paralytics perl-Elasticsearch.noarch: W: spelling-error %description -l en_US analytics -> analytic, analytic s, paralytics 2 packages and 1 specfiles checked; 0 errors, 2 warnings. > TODO: Do not install bench_cxn.pl or correct the shebang or the mode. Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Elasticsearch-0.75-3.fc21.noarch.rpm | sort -i | uniq -c 1 perl(:MODULE_COMPAT_5.18.1) 1 perl(Any::URI::Escape) 1 perl(Data::Dumper) 1 perl(Elasticsearch) 1 perl(Elasticsearch::Error) 1 perl(Elasticsearch::Util) 1 perl(Elasticsearch::Util::API::Path) 1 perl(Elasticsearch::Util::API::QS) 1 perl(Encode) 1 perl(File::Temp) 1 perl(HTTP::Headers) 1 perl(HTTP::Request) 1 perl(HTTP::Tiny) 1 perl(HTTP::Tiny) >= 0.036 1 perl(IO::Select) 1 perl(IO::Socket) 1 perl(IO::Socket::SSL) 1 perl(IO::Uncompress::Inflate) 1 perl(JSON) 1 perl(LWP::UserAgent) 1 perl(List::Util) 1 perl(Log::Any) 1 perl(Log::Any::Adapter) 1 perl(MIME::Base64) 1 perl(Module::Runtime) 1 perl(Moo) >= 1.003 1 perl(Moo::Role) 1 perl(POSIX) 1 perl(Scalar::Util) 1 perl(Sub::Exporter) 1 perl(Time::HiRes) 1 perl(Try::Tiny) 1 perl(URI) 1 perl(namespace::clean) 1 perl(overload) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 > TODO: You can filter unversioned dependencies: perl(HTTP::Tiny), perl(Moo). %{?perl_default_filter} +%global __requires_exclude perl\\(VMS|perl\\(Win32|perl\\(HTTP::Tiny\\)$ +%global __requires_exclude perl\\(VMS|perl\\(Win32|perl\\(Moo\\)$ TODO: The %global directive redefines the macro. As you can see, only the perl(Moo) disappeared. Moreover you overrides filter defined by %perl_default_filter. You need to append the filter like this: %global __requires_exclude %{?__requires_exclude:%__requires_exclude|}^perl\\((HTTP::Tiny|Moo)\\)$ > FIX: Run-require `perl(IO::Socket::SSL)' > (lib/Elasticsearch/Cxn/HTTPTiny.pm:63). Ok. > FIX: Run-require `perl(IO::Uncompress::Inflate)' > (lib/Elasticsearch/Role/Cxn/HTTP.pm:132). Ok. > FIX: Run-require `perl(MIME::Base64)' (lib/Elasticsearch/Role/Cxn/HTTP.pm:65). Ok. Package build in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6164913). Ok. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review