https://bugzilla.redhat.com/show_bug.cgi?id=1026743 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Elasticsearch.spec.old 2013-11-05 11:44:27.000000000 +0100 +++ perl-Elasticsearch.spec 2013-11-08 15:35:19.000000000 +0100 @@ -1,35 +1,43 @@ Name: perl-Elasticsearch Version: 0.75 -Release: 1%{?dist} +Release: 2%{?dist} Summary: Official client for Elasticsearch -License: Apache Software License +License: ASL 2.0 URL: http://search.cpan.org/dist/Elasticsearch/ Source0: http://www.cpan.org/authors/id/D/DR/DRTECH/Elasticsearch-%{version}.tar.gz BuildArch: noarch +BuildRequires: perl(lib) +BuildRequires: perl(overload) +BuildRequires: perl(strict) +BuildRequires: perl(warnings) BuildRequires: perl(Any::URI::Escape) BuildRequires: perl(Data::Dumper) BuildRequires: perl(Encode) -BuildRequires: perl(ExtUtils::MakeMaker) -BuildRequires: perl(HTTP::Tiny) -BuildRequires: perl(IO::Socket::SSL) -BuildRequires: perl(IO::Uncompress::Inflate) +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 +BuildRequires: perl(File::Temp) +BuildRequires: perl(HTTP::Headers) +BuildRequires: perl(HTTP::Request) +BuildRequires: perl(HTTP::Tiny) >= 0.036 +BuildRequires: perl(IO::Select) BuildRequires: perl(JSON) BuildRequires: perl(List::Util) BuildRequires: perl(Log::Any) BuildRequires: perl(Log::Any::Adapter) BuildRequires: perl(Log::Any::Adapter::Callback) BuildRequires: perl(LWP::UserAgent) +BuildRequires: perl(MIME::Base64) BuildRequires: perl(Module::Runtime) -BuildRequires: perl(Moo) +BuildRequires: perl(Moo) >= 1.003 BuildRequires: perl(Moo::Role) BuildRequires: perl(namespace::clean) BuildRequires: perl(Scalar::Util) BuildRequires: perl(Sub::Exporter) BuildRequires: perl(Test::Deep) BuildRequires: perl(Test::Exception) -BuildRequires: perl(Test::More) +BuildRequires: perl(Test::More) >= 0.98 +BuildRequires: perl(Time::HiRes) BuildRequires: perl(Try::Tiny) BuildRequires: perl(URI) BuildRequires: perl(YAML) @@ -38,10 +46,10 @@ %{?perl_default_filter} %description -Elasticsearch is the official Perl client for Elasticsearch, supported by -elasticsearch.com. Elasticsearch itself is a flexible and powerful open -source, distributed real-time search and analytics engine for the cloud. -You can read more about it on elasticsearch.org. +Elasticsearch is the official Perl client for Elasticsearch. Elasticsearch +itself is a flexible and powerful open source, distributed real-time search +and analytics engine for the cloud. You can read more about it on +http://elasticsearch.org/. %prep %setup -q -n Elasticsearch-%{version} @@ -51,7 +59,7 @@ make %{?_smp_mflags} %install -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \; @@ -61,11 +69,14 @@ make test %files -%doc Changes CONTRIBUTING.asciidoc cpanfile LICENSE README +%doc Changes CONTRIBUTING.asciidoc LICENSE README %{perl_vendorlib}/* %{_mandir}/man3/* %changelog +* Fri Nov 08 2013 Emmanuel Seyman <emmanuel@xxxxxxxxx> - 0.75-2 +- Take package review into account (#1026743) + * Sat Oct 26 2013 Emmanuel Seyman <emmanuel@xxxxxxxxx> - 0.75-1 - Update to 0.75 > TODO: Use valid URL instead of domain name in the description > (<http://www.elasticsearch.org/>). > TODO: Remove the /, supported by elasticsearch.com./ sentence. First it's > weird advertisment, second a domain cannot do a support. The real company's > name is `elasticsearch global B.V.'. %description -Elasticsearch is the official Perl client for Elasticsearch, supported by -elasticsearch.com. Elasticsearch itself is a flexible and powerful open -source, distributed real-time search and analytics engine for the cloud. -You can read more about it on elasticsearch.org. +Elasticsearch is the official Perl client for Elasticsearch. Elasticsearch +itself is a flexible and powerful open source, distributed real-time search +and analytics engine for the cloud. You can read more about it on +http://elasticsearch.org/. Ok. > FIX: Correct license name to `ASL 2.0' > (https://fedoraproject.org/wiki/Licensing:Main). -License: Apache Software License +License: ASL 2.0 Ok. > TODO: You can replace `%{__perl}' macros with plain `perl' command. Not addressed. > TODO: Replace PERL_INSTALL_ROOT argument with standard DESTDIR in the %install > section. -make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT +make pure_install DESTDIR=$RPM_BUILD_ROOT Ok. > TODO: You don't have to package `cpanfile'. The dependencies are declared at > RPM level. -%doc Changes CONTRIBUTING.asciidoc cpanfile LICENSE README +%doc Changes CONTRIBUTING.asciidoc LICENSE README Ok. > TODO: I recommend to qualify dependencies with versions: > perl(Test::More) >= 0.98, -BuildRequires: perl(Test::More) +BuildRequires: perl(Test::More) >= 0.98 Ok. > perl(ExtUtils::MakeMaker) >= 6.30, +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30 Ok. > perl(HTTP::Tiny) >= 0.036, +BuildRequires: perl(HTTP::Tiny) >= 0.036 Ok. > perl(Moo) >= 1.003. -BuildRequires: perl(Moo) +BuildRequires: perl(Moo) >= 1.003 Ok. > TODO: Build-require `perl(strict)' (Makefile.PL:2). +BuildRequires: perl(strict) Ok. > TODO: Build-require `perl(warnings)' (Makefile.PL:3). +BuildRequires: perl(warnings) Ok. > FIX: Build-require `perl(File::Temp)' (t/30_Logger/10_explicit.t:3). +BuildRequires: perl(File::Temp) Ok. > FIX: Build-require `perl(HTTP::Headers)' (lib/Elasticsearch/Cxn/LWP.pm:10). +BuildRequires: perl(HTTP::Headers) OK. > FIX: Build-require `perl(HTTP::Request)' (lib/Elasticsearch/Cxn/LWP.pm:11). +BuildRequires: perl(HTTP::Request) Ok. > TODO: Build-require `perl(IO::Select)' (lib/Elasticsearch/Role/CxnPool.pm:9). +BuildRequires: perl(IO::Select) Ok. > FIX: Do not build-require `perl(IO::Socket::SSL)'. It's not needed at > build-time. -BuildRequires: perl(IO::Socket::SSL) Ok. > FIX: Do not build-require `perl(IO::Uncompress::Inflate)'. It's not needed at > build-time. -BuildRequires: perl(IO::Uncompress::Inflate) Ok. > TODO: Build-require `perl(MIME::Base64)' > (lib/Elasticsearch/Role/Cxn/HTTP.pm:65). +BuildRequires: perl(MIME::Base64) Ok. > TODO: Build-require `perl(overload)' (lib/Elasticsearch/Error.pm:31). +BuildRequires: perl(overload) Ok. > FIX: Build-require `perl(Time::HiRes)' (lib/Elasticsearch/Role/CxnPool.pm:10). +BuildRequires: perl(Time::HiRes) Ok. > TODO: Build-require `perl(lib)' (t/30_Logger/30_log_methods.t:4). +BuildRequires: perl(lib) Ok. $ rpmlint perl-Elasticsearch.spec ../SRPMS/perl-Elasticsearch-0.75-2.fc21.src.rpm ../RPMS/noarch/perl-Elasticsearch-0.75-2.fc21.noarch.rpm perl-Elasticsearch.src: W: spelling-error %description -l en_US analytics -> analytic, analytic s, paralytics perl-Elasticsearch.noarch: W: spelling-error %description -l en_US analytics -> analytic, analytic s, paralytics perl-Elasticsearch.noarch: E: non-executable-script /usr/share/perl5/vendor_perl/bench_cxn.pl 0644L /usr/bin/env 2 packages and 1 specfiles checked; 1 errors, 2 warnings. > FIX: Correct the license name. Ok. > TODO: Do not install bench_cxn.pl or correct the shebang or the mode. Not addressed. $ rpm -q --requires -p ../RPMS/noarch/perl-Elasticsearch-0.75-2.fc21.noarch.rpm | sort -i | uniq -c 1 perl(Any::URI::Escape) 1 perl(Data::Dumper) 1 perl(Elasticsearch) 1 perl(Elasticsearch::Error) 1 perl(Elasticsearch::Util) 1 perl(Elasticsearch::Util::API::Path) 1 perl(Elasticsearch::Util::API::QS) 1 perl(Encode) 1 perl(File::Temp) 1 perl(HTTP::Headers) 1 perl(HTTP::Request) 1 perl(HTTP::Tiny) 1 perl(HTTP::Tiny) >= 0.036 1 perl(IO::Select) 1 perl(IO::Socket) 1 perl(JSON) 1 perl(List::Util) 1 perl(Log::Any) 1 perl(Log::Any::Adapter) 1 perl(LWP::UserAgent) 1 perl(:MODULE_COMPAT_5.18.1) 1 perl(Module::Runtime) 1 perl(Moo) 1 perl(Moo) >= 1.003 1 perl(Moo::Role) 1 perl(namespace::clean) 1 perl(overload) 1 perl(POSIX) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Sub::Exporter) 1 perl(Time::HiRes) 1 perl(Try::Tiny) 1 perl(URI) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 > TODO: You can filter unversioned dependencies: perl(HTTP::Tiny), perl(Moo). TODO: Not addressed. > FIX: Run-require `perl(IO::Socket::SSL)' > (lib/Elasticsearch/Cxn/HTTPTiny.pm:63). FIX: Not addressed. > FIX: Run-require `perl(IO::Uncompress::Inflate)' > (lib/Elasticsearch/Role/Cxn/HTTP.pm:132). FIX: Not addressed. > FIX: Run-require `perl(MIME::Base64)' (lib/Elasticsearch/Role/Cxn/HTTP.pm:65). FIX: Not addressed. $ resolvedeps rawhide ../RPMS/noarch/perl-Elasticsearch-0.75-2.fc21.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=6163988). Ok. Please correct all `FIX' items, consider fixing `TODO' items, and provide new SPEC file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review