https://bugzilla.redhat.com/show_bug.cgi?id=1015701 --- Comment #31 from Parag AN(पराग) <panemade@xxxxxxxxx> --- suggestions: 1) your source download link should be http://downloads.sourceforge.net/project/amiri/%{fontname}-%{version}.tar.bz2 2) good to always truncate your long lines with 80 characters per line # Sorts Mill tools (and others) which necessary to rebuild Amiri fonts isn't # released in Fedora yet. Enable the disabled-lines when rebuilding of Amiri # fonts possible. but I will suggest you better clean the spec and let not include comments and sorts mill tools information. We have many font packages which are not built from source so not a hard requirement. Just install binary files for now. 3) your fontconfig files should look neat as a)amiri-fontconfig.conf <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE fontconfig SYSTEM "../fonts.dtd"> <fontconfig> <alias> <family>sans-serif</family> <prefer> <family>Amiri</family> </prefer> </alias> <alias> <family>Amiri</family> <default> <family>sans-serif</family> </default> </alias> </fontconfig> b)amiri-quran-fontconfig.conf <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE fontconfig SYSTEM "../fonts.dtd"> <fontconfig> <alias> <family>sans-serif</family> <prefer> <family>Amiri Quran</family> </prefer> </alias> <alias> <family>Amiri Quran</family> <default> <family>sans-serif</family> </default> </alias> </fontconfig> 4) font package name should be [foundryname-]projectname[-fontfamilyname]-fonts, in lowercase. so you should install amiri-boldslanted.ttf, amiri-bold.ttf, amiri-regular.ttf, amiri-slanted.ttf from main amiri-fonts package and amiri-quran.ttf font from amiri-quran-fonts package 5) I don't think we need this font to be default Arabic font in Fedora. I will suggest to use 67 or 68 fontconfig priority like other fonts are using. Good to keep 67 priority as we have one example as 67-paktype-naskh-basic.conf 6) you should add -common package and not -doc package. Also, all other documentation files to -common package. 7) then, this -common be added to amiri-fonts and amiri-quran-fonts as Requires: amiri-fonts-common Feel free to ask me if you got any doubts in above. Provide new srpm that fixes above issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review