Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: system-config-date https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226455 ------- Additional Comments From kevin@xxxxxxxxx 2007-03-23 22:35 EST ------- Thanks for the excellent attention to all those items... All look good, except: >> 8. Is the "Conflicts: firstboot <= 1.3.26" needed? >> If it still is, couldn't it be converted to a: >> "Requires: firstboot => 1.3.26" instead? > >No. system-config packages shouldn't require firstboot at all. It is just that >they aren't compatible with older versions, thus the conflict. Conflicts are really nasty. They give the end user an ugly error that they don't know how to deal with and are generally unhelpful. ;( http://fedoraproject.org/wiki/PackagingDrafts/Conflicts When was firstboot 1.3.26 shipped? >> E: system-config-date script-without-shebang >> /usr/share/system-config-date/date_gui.py >> >> Suggest: All of these should be mode 644 since they are just imported by the >> main program? No need for them to be executable. > >Not changing modes now as it might break things. Might do later. I can't think of what might break, but I guess it's up to you... So, no hard blockers, but it would be nice to fix the Conflicts... any thoughts? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review