Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: dialog https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225693 ------- Additional Comments From pertusus@xxxxxxx 2007-03-23 19:32 EST ------- * I suggest not messing with the original samples directory but instead do something like: rm -rf __distributed_samples mkdir __distributed_samples cp -a samples __distributed_samples fgrep -l -r perl __distributed_samples/samples|xargs rm find __distributed_samples/samples -type f -print0 |xargs -0 chmod a-x and in %files %doc __distributed_samples/samples * More fundamentaly why removing the doc files executable bits? You could remove them on most of the copifuncs/copi.* files (except common.funcs, admin.funcs, copi.wheel, copi.rcnews), since they are concatenated and chmoded after that. In general I think that scripts should keep their exec bits. Another issue is that you remove ./msgbox4-utf8 ./msgbox4-eucjp that happens to have the perl string in them... And also the perl files you remove should certainly be there. * --includedir=/usr/include/dialog should certainly be --includedir=%{_includedir}/dialog * devel should not have COPYING dialog.lsm README since they are already in main package. * suggestion: replace %defattr(-,root,root) with %defattr(-,root,root,-) * devel package certainly requires ncurses-devel * the header files include a lot of ./configure conditionals. Thats very bad and, in general shouldn't be needed. Moreover some are completely unneeded and not even set. This should certainly be worked on with upstream. * there are no shared libs because libtool isn't really used. the configure switch is --with-libtool libtool should then be a BuildRequires. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review